From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support Date: Tue, 07 Jul 2009 15:56:09 +0300 Message-ID: <4A5345E9.6050502@redhat.com> References: <20090706202742.14222.65548.stgit@dev.haskins.net> <20090706203321.14222.67866.stgit@dev.haskins.net> <20090707112024.GA3647@redhat.com> <4A533C4C.7020202@novell.com> <20090707124810.GD3647@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gregory Haskins , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36641 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbZGGMxm (ORCPT ); Tue, 7 Jul 2009 08:53:42 -0400 In-Reply-To: <20090707124810.GD3647@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/07/2009 03:48 PM, Michael S. Tsirkin wrote: >>>> + >>>> + __kvm_io_bus_unregister_dev(bus,&p->dev); >>>> + iosignalfd_release(p); >>>> >>>> >>> a single deassign removed multiple irqfds? Looks ugly. >>> >>> >> Avi requested this general concept. >> > > Really? Avi, could you explain? I would think each > assign needs to be matched with 1 deassign. No? > Doesn't it follow naturally? How can a single deassign remove multiple fds (unless all were registered with exactly the same arguments)? Maybe we should instead detect that the duplicate iosignaldfds are registered. Note that we do need to allow the same fd to be multiple times, but not with exactly the same address/match etc. -- error compiling committee.c: too many arguments to function