From: Avi Kivity <avi@redhat.com>
To: "Zhai, Edwin" <edwin.zhai@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM:VMX: Add support for Pause-Loop Exiting
Date: Wed, 08 Jul 2009 07:43:56 +0300 [thread overview]
Message-ID: <4A54240C.3050407@redhat.com> (raw)
In-Reply-To: <20090708033235.GA577@edwin-srv.sh.intel.com>
On 07/08/2009 06:32 AM, Zhai, Edwin wrote:
>
> /*
> + * Indicate a busy-waiting vcpu in spinlock. We do not enable the PAUSE
> + * exiting, so only get here on cpu with PAUSE-Loop-Exiting.
> + */
> +static int handle_pause(struct kvm_vcpu *vcpu,
> + struct kvm_run *kvm_run)
> +{
> + skip_emulated_instruction(vcpu);
> + yield();
> + return 1;
> +}
> +
>
yield() does nothing in Linux. Please look at
http://lkml.org/lkml/2009/5/11/294 for what needs to be added to the
scheduler (that message is part of a thread discussing the same feature
for svm).
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2009-07-08 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 3:32 [PATCH] KVM:VMX: Add support for Pause-Loop Exiting Zhai, Edwin
2009-07-08 4:43 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A54240C.3050407@redhat.com \
--to=avi@redhat.com \
--cc=edwin.zhai@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox