From: Avi Kivity <avi@redhat.com>
To: Stephane Bakhos <nuitari-kvm@nuitari.net>
Cc: kvm@vger.kernel.org
Subject: Re: Tap initialization
Date: Wed, 08 Jul 2009 07:57:39 +0300 [thread overview]
Message-ID: <4A542743.8010502@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907071431250.13974@anvil.nuitari.net>
On 07/07/2009 09:48 PM, Stephane Bakhos wrote:
> I've been having some problem with recent releases when it comes to
> tap initialization. It seems that the script is ran after the tap is
> opened. I think this is a bit weird and useless as I want the script
> to setup the tap by itself.
>
> In net.c, the initialization (I assume) happen in
> static int net_tap_init
>
> setup_script is called after tap_open with the fd from tap_open as a
> parameter.
>
> However in setup_script, the fd is basically not used.
>
> Would there be any reason not to remove the fd parameter to
> setup_script, and then call setup_script before tap_open ?
>
> I've tried it with kvm-86 and it seems to work
You can get the same effect by setting up tap before launching qemu, and
using qemu -net tap,ifname=...,script=no.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-07-08 4:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 18:48 Tap initialization Stephane Bakhos
2009-07-08 4:57 ` Avi Kivity [this message]
2009-07-08 5:17 ` Stephane Bakhos
2009-07-12 9:03 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A542743.8010502@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nuitari-kvm@nuitari.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox