From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/8] move qemu-kvm.c to kvm-all.c Date: Wed, 08 Jul 2009 16:23:39 +0300 Message-ID: <4A549DDB.6030200@redhat.com> References: <1247058542-31211-1-git-send-email-glommer@redhat.com> <1247058542-31211-2-git-send-email-glommer@redhat.com> <1247058542-31211-3-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43318 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451AbZGHNVK (ORCPT ); Wed, 8 Jul 2009 09:21:10 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n68DLAfM031282 for ; Wed, 8 Jul 2009 09:21:10 -0400 In-Reply-To: <1247058542-31211-3-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2009 04:08 PM, Glauber Costa wrote: > Big plan to start sharing code with upstream. > > This patch is very brittle - if qemu-kvm.c changes, it won't apply. I suggest to simply add #include "qemu-kvm.c" and remove it from the makefile. After I apply it, I'll perform the #include and remove qemu-kvm.c. -- error compiling committee.c: too many arguments to function