From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure Date: Wed, 08 Jul 2009 16:44:07 +0300 Message-ID: <4A54A2A7.7040309@redhat.com> References: <1247058542-31211-1-git-send-email-glommer@redhat.com> <1247058542-31211-2-git-send-email-glommer@redhat.com> <1247058542-31211-3-git-send-email-glommer@redhat.com> <1247058542-31211-4-git-send-email-glommer@redhat.com> <1247058542-31211-5-git-send-email-glommer@redhat.com> <1247058542-31211-6-git-send-email-glommer@redhat.com> <1247058542-31211-7-git-send-email-glommer@redhat.com> <1247058542-31211-8-git-send-email-glommer@redhat.com> <4A549EBF.5040900@redhat.com> <20090708133941.GY3528@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, jan.kiszka@web.de To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48804 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754343AbZGHNlj (ORCPT ); Wed, 8 Jul 2009 09:41:39 -0400 In-Reply-To: <20090708133941.GY3528@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2009 04:39 PM, Glauber Costa wrote: > On Wed, Jul 08, 2009 at 04:27:27PM +0300, Avi Kivity wrote: > >> On 07/08/2009 04:09 PM, Glauber Costa wrote: >> >>> Signed-off-by: Glauber Costa >>> --- >>> kvm-all.c | 27 ++++++++++++++++++--------- >>> qemu-kvm.h | 6 +++--- >>> target-i386/kvm.c | 4 ++-- >>> 3 files changed, 23 insertions(+), 14 deletions(-) >>> >>> >>> >> Did you test the functionality to ensure we do not regress? >> > just briefly. To be honest, I'd feel much more confortable > if Jan could give it a try. > A Jan try (+review) will definitely help. -- error compiling committee.c: too many arguments to function