From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Subject: Re: [KVM_AUTOTEST] add kvm hugepage variant and test Date: Thu, 09 Jul 2009 14:55:12 +0200 Message-ID: <4A55E8B0.1@redhat.com> References: <119650285.208601247142612126.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: KVM list , Jason Wang To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53824 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756632AbZGIMzQ (ORCPT ); Thu, 9 Jul 2009 08:55:16 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n69CtFu2013915 for ; Thu, 9 Jul 2009 08:55:16 -0400 In-Reply-To: <119650285.208601247142612126.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Michael, actually it's necessarily. qemu-kvm only put this message into the=20 output and continue booting the guest without hugepage support. Autotes= t=20 than runs all the test. Later in the output is no mention about this.=20 You have to predict that this happend and look at debug output of all=20 particular tests to see if qemu didn't produced this message. Using this check if qemu-kvm can't allocate the hugepage memory it fail= s=20 this test, log this information and continue with next variant. Dne 9.7.2009 14:30, Michael Goldish napsal(a): > I don't think you need to explicitly check for a memory allocation > failure in VM.create() ("qemu produced some output ..."). > VM.create() already makes sure the VM is started successfully, and > prints informative failure messages if there's any problem. > > ----- "Luk=C3=A1=C5=A1 Doktor" wrote: > >> This patch adds kvm_hugepage variant. It prepares the host system an= d >> start vm with -mem-path option. It does not clean after itself, >> because >> it's impossible to unmount and free hugepages before all guests are >> destroyed. >> >> There is also added autotest.libhugetlbfs test. >> >> I need to ask you what to do with change of qemu parameter. Newest >> versions are using -mempath insted of -mem-path. This is impossible = to >> fix using current config file. I can see 2 solutions: >> 1) direct change in kvm_vm.py (parse output and try another param) >> 2) detect qemu capabilities outside and create additional layer >> (better >> for future occurrence) > > I'll have to think about this a little before answering. > >> Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5 > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html