From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg
Date: Fri, 10 Jul 2009 13:43:41 -0500
Message-ID: <4A578BDD.8010209@codemonkey.ws>
References: <1245722714.22246.424.camel@yhuang-dev.sh.intel.com> <20090710183019.GB8725@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Huang Ying <ying.huang@intel.com>, Avi Kivity <avi@redhat.com>,
	Andi Kleen <andi@firstfloor.org>, qemu-devel@nongnu.org,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from qw-out-2122.google.com ([74.125.92.27]:9732 "EHLO
	qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750991AbZGJSnp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 10 Jul 2009 14:43:45 -0400
Received: by qw-out-2122.google.com with SMTP id 9so398429qwb.37
        for <kvm@vger.kernel.org>; Fri, 10 Jul 2009 11:43:44 -0700 (PDT)
In-Reply-To: <20090710183019.GB8725@lst.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Christoph Hellwig wrote:
> On Tue, Jun 23, 2009 at 10:05:14AM +0800, Huang Ying wrote:
>   
>> - MCE features are initialized when VCPU is intialized according to CPUID.
>> - A monitor command "mce" is added to inject a MCE.
>> - A new interrupt mask: CPU_INTERRUPT_MCE is added to inject the MCE.
>>     
>
> This patch (now in the qemu tree) breaks compilation for me on i386:
>   

> /home/hch/work/qemu/target-i386/helper.c: In function
> 'cpu_inject_x86_mce':
> /home/hch/work/qemu/target-i386/helper.c:1510: error: left shift count >= width of type
>   

I pushed a fix to master.

Regards,

Anthony Liguori