From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Reduce interface between kvm general and kvm arch.
Date: Sun, 12 Jul 2009 14:03:17 +0300 [thread overview]
Message-ID: <4A59C2F5.4080102@redhat.com> (raw)
In-Reply-To: <1247142834-16993-2-git-send-email-gleb@redhat.com>
On 07/09/2009 03:33 PM, Gleb Natapov wrote:
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 05b6bc7..cf20dc1 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1666,9 +1666,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
> for (;;) {
> prepare_to_wait(&vcpu->wq,&wait, TASK_INTERRUPTIBLE);
>
> - if ((kvm_arch_interrupt_allowed(vcpu)&&
> - kvm_cpu_has_interrupt(vcpu)) ||
> - kvm_arch_vcpu_runnable(vcpu)) {
> + if (kvm_arch_vcpu_runnable(vcpu)) {
> set_bit(KVM_REQ_UNHALT,&vcpu->requests);
> break;
> }
>
s390 has:
int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu)
{
/* kvm common code refers to this, but never calls it */
BUG();
return 0;
}
So this needs to be updated. Please coordinate with the s390 folks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-07-12 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 12:33 [PATCH] Reduce interface between kvm general and kvm arch Gleb Natapov
2009-07-12 11:03 ` Avi Kivity [this message]
2009-07-12 11:02 ` Gleb Natapov
2009-07-12 11:09 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A59C2F5.4080102@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox