From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Reduce interface between kvm general and kvm arch. Date: Sun, 12 Jul 2009 14:09:48 +0300 Message-ID: <4A59C47C.9050507@redhat.com> References: <1247142834-16993-2-git-send-email-gleb@redhat.com> <4A59C2F5.4080102@redhat.com> <20090712110224.GZ28046@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:57833 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbZGLLGy (ORCPT ); Sun, 12 Jul 2009 07:06:54 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6CB6rEH015931 for ; Sun, 12 Jul 2009 07:06:54 -0400 In-Reply-To: <20090712110224.GZ28046@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/12/2009 02:02 PM, Gleb Natapov wrote: >> >> s390 has: >> >> >> int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu) >> { >> /* kvm common code refers to this, but never calls it */ >> BUG(); >> return 0; >> } >> >> So this needs to be updated. Please coordinate with the s390 folks. >> >> > s390 never calls kvm_vcpu_block(). They implement their own blocking. > > Right; applied. -- error compiling committee.c: too many arguments to function