Re: [Autotest] [PATCH] Assign an UUID for each VM in kvm command line

[Dor Laor <dlaor@redhat.com>]

On 07/15/2009 12:12 PM, Yolkfull Chow wrote:
> Would submit this patch which is from our internal kvm-autotest patches submitted by Jason.
> So that we could go on test case about parameters verification(UUID, DMI data etc).
>
> Signed-off-by: Yolkfull Chow<yzhou@redhat.com>
> ---
>   client/tests/kvm/kvm_vm.py |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index 503f636..68cc235 100644
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -287,6 +287,10 @@ class VM:
>           elif params.get("display") == "nographic":
>               qemu_cmd += " -nographic"
>
> +        uuid = os.popen("cat /proc/sys/kernel/random/uuid").readline().strip()
> +        if uuid:
> +            qemu_cmd += " -uuid %s" % uuid

If you'll change the uuid on every run, the guest will notice that. Some 
guest (M$) might not love it.
Why not use a static uuid or even just test uuid in a specific test 
without having it in all tests?

btw: why you're at it, please add uuid to the block devices too.
+ the -smbios option.

Thanks,
dor

> +
>           return qemu_cmd
>
>