From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
Date: Wed, 15 Jul 2009 18:03:26 +0200
Message-ID: <4A5DFDCE.8000604@redhat.com>
References: <1245862739.6278.7.camel@localhost>	<1245998284.6278.99.camel@localhost>	<4A447C8D.5000104@kevin-wolf.de>	<1246063310.6278.115.camel@localhost>		<1246511321.6429.31.camel@localhost>	<4A4C754D.10109@redhat.com>	 <4A4CAD86.9020607@us.ibm.com>	<4A4CB39F.5070506@redhat.com>	 <1247041831.6297.12.camel@localhost>	<1247644283.14246.3.camel@localhost>	<f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com> <4A5DF252.50408@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Blue Swirl <blauwirbel@gmail.com>, Kevin Wolf <kwolf@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>, linuxram@us.ibm.com,
	qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@web.de>,
	Paul Brook <paul@codesourcery.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:56721 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755234AbZGOQFl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 15 Jul 2009 12:05:41 -0400
In-Reply-To: <4A5DF252.50408@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/15/09 17:14, Anthony Liguori wrote:
> Blue Swirl wrote:
>> I bet this won't compile on win32.
>>
>> Instead of this (IMHO doomed) escape approach, maybe the filename
>> parameter could be specified as the next argument, for example:
>> -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filename with
>> funky characters like ',' ':' & '!'"
>
> -drive name=hda,if=ide,cache=off -hda foo.img
> -drive name=vda,if=virtio,cache=writeback -vda foo.img
> -drive name=sdb,if=scsi,unit=1 -sdb boo.img
>
> But Paul has long objected to having -vda or -sda syntaxes. I do agree
> though that the most sane thing to do is to make the filename an
> independent argument.

Jumping in here as I'm looking into this from the qdev-ifying point of 
view ;)

I'd like to move to a model where -drive adds host-side state only and
the actual disks are added via -device, i.e. something like

   -drive if=none,name=foo,file=/path/to/file
   -device virtio-blk-pci,drive=foo

Instead of using '-drive if=none' we could use some other syntax where 
the filename can be passed as separate argument.  Can switches have two 
arguments?  If so, maybe this:

   -hostdrive $file $options

comments?

cheers,
   Gerd