From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] rev3: support colon in filenames Date: Wed, 15 Jul 2009 17:41:04 -0500 Message-ID: <4A5E5B00.10304@us.ibm.com> References: <1246063310.6278.115.camel@localhost> <1246511321.6429.31.camel@localhost> <4A4C754D.10109@redhat.com> <4A4CAD86.9020607@us.ibm.com> <4A4CB39F.5070506@redhat.com> <20090715181405.GB3056@shareable.org> <4A5E4206.20602@web.de> <20090715213635.GN3056@shareable.org> <4A5E4D33.9070901@web.de> <4A5E5545.5060603@us.ibm.com> <20090715223949.GS3056@shareable.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Kevin Wolf , linuxram@us.ibm.com, qemu-devel@nongnu.org, kvm-devel To: Jamie Lokier Return-path: Received: from e39.co.us.ibm.com ([32.97.110.160]:44754 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958AbZGOWlJ (ORCPT ); Wed, 15 Jul 2009 18:41:09 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e39.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6FMaZXf032038 for ; Wed, 15 Jul 2009 16:36:35 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6FMf67D225956 for ; Wed, 15 Jul 2009 16:41:06 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6FMf5Aa003432 for ; Wed, 15 Jul 2009 16:41:06 -0600 In-Reply-To: <20090715223949.GS3056@shareable.org> Sender: kvm-owner@vger.kernel.org List-ID: Jamie Lokier wrote: > Anthony Liguori wrote: > >> Jan Kiszka wrote: >> >>> We would still have to deal with the fact that so far '\' had no special >>> meaning on Windows - except that is was the well-known path separator. >>> So redefining its meaning would break a bit... >>> >>> >> That's the problem. You will break existing Windows users. >> >> I know this goes against the current momentum in qemu, but overloading >> one option with a bunch of parameters seems absolutely silly to me. >> >> IMHO, -drive file=foo.img,if=virtio,cache=off should have always been at >> least three parameters. >> > > That's fine for command lines. I don't necessarily disagree with you. > > But how do you propose to handle paths in monitor commands, when the > path contains a space/quote/whatever as it often does on Windows ("My > Documents", "Program Files")? > Same basic rules apply. The monitor should use shell-style quoting. -- Regards, Anthony Liguori