From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
Date: Thu, 16 Jul 2009 09:43:30 +0200
Message-ID: <4A5EDA22.2010605@redhat.com>
References: <1245862739.6278.7.camel@localhost>	 <1245998284.6278.99.camel@localhost> <4A447C8D.5000104@kevin-wolf.de>	 <1246063310.6278.115.camel@localhost>	 <1246511321.6429.31.camel@localhost>	 <4A4C754D.10109@redhat.com>	 <4A4CAD86.9020607@us.ibm.com>	 <4A4CB39F.5070506@redhat.com>	 <1247041831.6297.12.camel@localhost>	 <1247644283.14246.3.camel@localhost>	 <f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com> <1247729967.14246.139.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@us.ibm.com>,
	Jan Kiszka <jan.kiszka@web.de>, kvm-devel <kvm@vger.kernel.org>
To: linuxram@us.ibm.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:45207 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751625AbZGPHos (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 16 Jul 2009 03:44:48 -0400
In-Reply-To: <1247729967.14246.139.camel@localhost>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Ram Pai schrieb:
> On Wed, 2009-07-15 at 18:04 +0300, Blue Swirl wrote:
>> On 7/15/09, Ram Pai <linuxram@us.ibm.com> wrote:
>>> Problem: It is impossible to feed filenames with the character colon because
>>>  qemu interprets such names as a protocol. For example filename scsi:0, is
>>>  interpreted as a protocol by name "scsi".
>>>  --- a/block/raw-posix.c
>>>  +++ b/block/raw-posix.c
>>>  +static int qemu_open(const char *filename, int flags, ...)
>>>  --- a/block/raw-win32.c
>>>  +++ b/block/raw-win32.c
>>>  +    fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
>> I bet this won't compile on win32.
> 
> yes. good catch. fix is in the next revision(rev 6). However I do not
> have a setup to compile and test changes in win32-raw.c . I will have to
> rely on somebody to do the testing. 

It's not that complicated to set up a mingw cross build environment.
Have you tried that? At least it would help you to catch compile errors.
(And I usually run it in Wine then to check that it's not completely broken)

Kevin