From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API Date: Thu, 16 Jul 2009 13:28:54 -0400 Message-ID: <4A5F6356.9080505@redhat.com> References: <20090716155652.6266.39970.stgit@localhost.localdomain> <20090716155700.6266.71011.stgit@localhost.localdomain> <20090716163708.GB5804@merkur.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm In-Reply-To: <20090716163708.GB5804@merkur.ravnborg.org> List-Unsubscribe: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org List-Id: kvm.vger.kernel.org Sam Ravnborg wrote: >> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h >> new file mode 100644 >> index 0000000..01e079a >> --- /dev/null >> +++ b/arch/x86/include/asm/inat.h >> @@ -0,0 +1,125 @@ >> +#ifndef _ASM_INAT_INAT_H >> +#define _ASM_INAT_INAT_H > > [With reference to comment on patch 2/12...] > You create inat.h here. > Could you investigave what is needed to factor out the stuff > needed from userspace so we can avoid the ugly havk where > you redefine types.h? Sorry, I'm a bit confusing. Would you mean that I should break down user_include.h and add those redefined types in inat.h? > Maybe create a inat_types.h + inat.h as we do in other cases? And inat_types.h has two parts, one for kernel, and one for userspace(which is moved from user_include.h), is that right? Thank you, > > Same for the other files that requred the types.h hack. > > Sam > -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com