From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -tip -v12 02/11] x86: x86 instruction decoder build-time selftest Date: Thu, 16 Jul 2009 16:16:45 -0400 Message-ID: <4A5F8AAD.1060404@redhat.com> References: <20090716155652.6266.39970.stgit@localhost.localdomain> <20090716155706.6266.79022.stgit@localhost.localdomain> <20090716162947.GA5804@merkur.ravnborg.org> <4A5F6571.3020002@redhat.com> <20090716195542.GA5994@merkur.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm In-Reply-To: <20090716195542.GA5994@merkur.ravnborg.org> List-Unsubscribe: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org List-Id: kvm.vger.kernel.org Sam Ravnborg wrote: >>>> + cmd_posttest = objdump -d $(objtree)/vmlinux | awk -f $(srctree)/arch/x86/scripts/distill.awk | $(obj)/test_get_len >>>> + >>> You are using the native objdump here. >>> But I assume this fails miserably when you build x86 on a powerpc host. >>> In other words - you broke an allyesconfig build for -next... >>> We have $(OBJDUMP) for this. >> Ah, I see... Would you know actual name of x86-objdump on the powerpc >> (or any other crosscompiling host)? I just set "OBJDUMP=objdump" is OK? >> I'm not so sure about cross-compiling kernel... > > Replacing objdump with $(OBJDUMP) will do the trick. > We set OBJDUMP to the correct value in the top-level makefile. > > Are there any parts of your user-space program that rely > on the host is little-endian? > If it does then it would fail on a power-pc target despite using the > correct objdump. Hmm, as far as I can see, the result of get_next() macro with the types more than two bytes(s16, s32...) might be effected. But it doesn't effect get_insn_len test because those values are ignored. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com