Well, thank you for notifications, I'll keep them in my mind. Also the problem with mempath vs. mem-path is solved. It was just a misspell in one version of KVM. * fixed patch attached Dne 20.7.2009 14:58, Lucas Meneghel Rodrigues napsal(a): > On Fri, 2009-07-10 at 12:01 +0200, Lukáš Doktor wrote: >> After discussion I split the patches. > > Hi Lukáš, sorry for the delay answering your patch. Looks good to me in > general, I have some remarks to make: > > 1) When posting patches to the autotest kvm tests, please cross post the > autotest mailing list (autotest@test.kernel.org) and the KVM list. > > 2) About scripts to prepare the environment to perform tests - we've had > some discussion about including shell scripts on autotest. Bottom line, > autotest has a policy of not including non python code when possible > [1]. So, would you mind re-creating your hugepage setup code in python > and re-sending it? > > Thanks for your contribution, looking forward getting it integrated to > our tests. > > [1] Unless when it is not practical for testing purposes - writing tests > in C is just fine, for example. > >> This patch adds kvm_hugepage variant. It prepares the host system and >> start vm with -mem-path option. It does not clean after itself, because >> it's impossible to unmount and free hugepages before all guests are >> destroyed. >> >> I need to ask you what to do with change of qemu parameter. Newest >> versions are using -mempath insted of -mem-path. This is impossible to >> fix using current config file. I can see 2 solutions: >> 1) direct change in kvm_vm.py (parse output and try another param) >> 2) detect qemu capabilities outside and create additional layer (better >> for future occurrence) >> >> Dne 9.7.2009 11:24, Lukáš Doktor napsal(a): >>> This patch adds kvm_hugepage variant. It prepares the host system and >>> start vm with -mem-path option. It does not clean after itself, because >>> it's impossible to unmount and free hugepages before all guests are >>> destroyed. >>> >>> There is also added autotest.libhugetlbfs test. >>> >>> I need to ask you what to do with change of qemu parameter. Newest >>> versions are using -mempath insted of -mem-path. This is impossible to >>> fix using current config file. I can see 2 solutions: >>> 1) direct change in kvm_vm.py (parse output and try another param) >>> 2) detect qemu capabilities outside and create additional layer (better >>> for future occurrence) >>> >>> Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5 >