From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Subject: Re: [KVM_AUTOTEST] add kvm hugepage variant Date: Tue, 21 Jul 2009 18:04:11 +0200 Message-ID: <4A65E6FB.1090901@redhat.com> References: <4A55B759.5080302@redhat.com> <4A57118F.3030907@redhat.com> <1248094728.5318.18.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060306000708010304040306" Cc: KVM list , Jason Wang , Michael Goldish , Autotest mailing list To: Lucas Meneghel Rodrigues Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59026 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755422AbZGUQEW (ORCPT ); Tue, 21 Jul 2009 12:04:22 -0400 In-Reply-To: <1248094728.5318.18.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------060306000708010304040306 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Well, thank you for notifications, I'll keep them in my mind. Also the problem with mempath vs. mem-path is solved. It was just a misspell in one version of KVM. * fixed patch attached Dne 20.7.2009 14:58, Lucas Meneghel Rodrigues napsal(a): > On Fri, 2009-07-10 at 12:01 +0200, Lukáš Doktor wrote: >> After discussion I split the patches. > > Hi Lukáš, sorry for the delay answering your patch. Looks good to me in > general, I have some remarks to make: > > 1) When posting patches to the autotest kvm tests, please cross post the > autotest mailing list (autotest@test.kernel.org) and the KVM list. > > 2) About scripts to prepare the environment to perform tests - we've had > some discussion about including shell scripts on autotest. Bottom line, > autotest has a policy of not including non python code when possible > [1]. So, would you mind re-creating your hugepage setup code in python > and re-sending it? > > Thanks for your contribution, looking forward getting it integrated to > our tests. > > [1] Unless when it is not practical for testing purposes - writing tests > in C is just fine, for example. > >> This patch adds kvm_hugepage variant. It prepares the host system and >> start vm with -mem-path option. It does not clean after itself, because >> it's impossible to unmount and free hugepages before all guests are >> destroyed. >> >> I need to ask you what to do with change of qemu parameter. Newest >> versions are using -mempath insted of -mem-path. This is impossible to >> fix using current config file. I can see 2 solutions: >> 1) direct change in kvm_vm.py (parse output and try another param) >> 2) detect qemu capabilities outside and create additional layer (better >> for future occurrence) >> >> Dne 9.7.2009 11:24, Lukáš Doktor napsal(a): >>> This patch adds kvm_hugepage variant. It prepares the host system and >>> start vm with -mem-path option. It does not clean after itself, because >>> it's impossible to unmount and free hugepages before all guests are >>> destroyed. >>> >>> There is also added autotest.libhugetlbfs test. >>> >>> I need to ask you what to do with change of qemu parameter. Newest >>> versions are using -mempath insted of -mem-path. This is impossible to >>> fix using current config file. I can see 2 solutions: >>> 1) direct change in kvm_vm.py (parse output and try another param) >>> 2) detect qemu capabilities outside and create additional layer (better >>> for future occurrence) >>> >>> Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5 > --------------060306000708010304040306 Content-Type: text/plain; name="kvm_hugepage.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="kvm_hugepage.patch" ZGlmZiAtLWdpdCBhL2NsaWVudC90ZXN0cy9rdm0va3ZtX3Rlc3RzLmNmZy5zYW1wbGUgYi9j bGllbnQvdGVzdHMva3ZtL2t2bV90ZXN0cy5jZmcuc2FtcGxlCmluZGV4IDViZDZlYjguLjcw ZTI5MGQgMTAwNjQ0Ci0tLSBhL2NsaWVudC90ZXN0cy9rdm0va3ZtX3Rlc3RzLmNmZy5zYW1w bGUKKysrIGIvY2xpZW50L3Rlc3RzL2t2bS9rdm1fdGVzdHMuY2ZnLnNhbXBsZQpAQCAtNTU1 LDYgKzU1NSwxMyBAQCB2YXJpYW50czoKICAgICAgICAgb25seSBkZWZhdWx0CiAgICAgICAg IGltYWdlX2Zvcm1hdCA9IHJhdwogCit2YXJpYW50czoKKyAgICAtIEBrdm1fc21hbGxwYWdl czoKKyAgICAtIGt2bV9odWdlcGFnZXM6CisgICAgICAgIGh1Z2VwYWdlX3BhdGggPSAvbW50 L2h1Z2VwYWdlCisgICAgICAgIHByZV9jb21tYW5kID0gIi91c3IvYmluL3B5dGhvbiBzY3Jp cHRzL2h1Z2VwYWdlLnB5IgorICAgICAgICBleHRyYV9wYXJhbXMgKz0gIiAtbWVtLXBhdGgg L21udC9odWdlcGFnZSIKKwogCiB2YXJpYW50czoKICAgICAtIEBiYXNpYzoKQEAgLTU2OCw2 ICs1NzUsNyBAQCB2YXJpYW50czoKICAgICAgICAgb25seSBGZWRvcmEuOC4zMgogICAgICAg ICBvbmx5IGluc3RhbGwgc2V0dXAgYm9vdCBzaHV0ZG93bgogICAgICAgICBvbmx5IHJ0bDgx MzkKKyAgICAgICAgb25seSBrdm1fc21hbGxwYWdlcwogICAgIC0gQHNhbXBsZTE6CiAgICAg ICAgIG9ubHkgcWNvdzIKICAgICAgICAgb25seSBpZGUKZGlmZiAtLWdpdCBhL2NsaWVudC90 ZXN0cy9rdm0va3ZtX3ZtLnB5IGIvY2xpZW50L3Rlc3RzL2t2bS9rdm1fdm0ucHkKaW5kZXgg NDhmMjkxNi4uMmI5N2NjYyAxMDA2NDQKLS0tIGEvY2xpZW50L3Rlc3RzL2t2bS9rdm1fdm0u cHkKKysrIGIvY2xpZW50L3Rlc3RzL2t2bS9rdm1fdm0ucHkKQEAgLTQxMiw2ICs0MTIsMTMg QEAgY2xhc3MgVk06CiAgICAgICAgICAgICAgICAgc2VsZi5kZXN0cm95KCkKICAgICAgICAg ICAgICAgICByZXR1cm4gRmFsc2UKIAorICAgICAgICAgICAgaWYgb3V0cHV0OgorICAgICAg ICAgICAgICAgIGxvZ2dpbmcuZGVidWcoInFlbXUgcHJvZHVjZWQgc29tZSBvdXRwdXQ6XG4l cyIsIG91dHB1dCkKKyAgICAgICAgICAgICAgICBpZiAiYWxsb2NfbWVtX2FyZWEiIGluIG91 dHB1dDoKKyAgICAgICAgICAgICAgICAgICAgbG9nZ2luZy5lcnJvcigiQ291bGQgbm90IGFs bG9jYXRlIGh1Z2VwYWdlIG1lbW9yeSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICIgLS0gcWVtdSBjb21tYW5kOlxuJXMiLCBxZW11X2NvbW1hbmQpCisgICAgICAgICAg ICAgICAgICAgIHJldHVybiBGYWxzZQorCiAgICAgICAgICAgICBsb2dnaW5nLmRlYnVnKCJW TSBhcHBlYXJzIHRvIGJlIGFsaXZlIHdpdGggUElEICVkIiwgc2VsZi5waWQpCiAgICAgICAg ICAgICByZXR1cm4gVHJ1ZQogCgpkaWZmIC1OYXJ1cCBhL2NsaWVudC90ZXN0cy9rdm0vc2Ny aXB0cy9odWdlcGFnZS5weSBiL2NsaWVudC90ZXN0cy9rdm0vc2NyaXB0cy8KaHVnZXBhZ2Uu cHkKLS0tIGEvY2xpZW50L3Rlc3RzL2t2bS9zY3JpcHRzL2h1Z2VwYWdlLnB5IDE5NzAtMDEt MDEgMDE6MDA6MDAuMDAwMDAwMDAwICswMTAwCisrKyBhL2NsaWVudC90ZXN0cy9rdm0vc2Ny aXB0cy9odWdlcGFnZS5weSAgICAyMDA5LTA3LTIxIDE2OjQ3OjAwLjAwMDAwMDAwMCArMDIw MApAQCAtMCwwICsxLDYzIEBACisjIS91c3IvYmluL3B5dGhvbgorIyAtKi0gY29kaW5nOiB1 dGYtOCAtKi0KKyMgQWxvY2F0ZXMgZW5vdWdoIGh1Z2VwYWdlcyBhbmQgbW91bnQgaHVnZXRs YmZzCitpbXBvcnQgb3MsIHN5cywgdGltZQorCisjIFZhcmlhYmxlcyBjaGVjayAmIHNldAor dm1zID0gb3MuZW52aXJvblsnS1ZNX1RFU1Rfdm1zJ10uc3BsaXQoKS5fX2xlbl9fKCkKK3Ry eToKKyAgICBtYXhfdm1zID0gaW50KG9zLmVudmlyb25bJ0tWTV9URVNUX21heF92bXMnXSkK K2V4Y2VwdCBLZXlFcnJvcjoKKyAgICBtYXhfdm1zID0gMAorbWVtID0gaW50KG9zLmVudmly b25bJ0tWTV9URVNUX21lbSddKQoraHVnZXBhZ2VfcGF0aCA9IG9zLmVudmlyb25bJ0tWTV9U RVNUX2h1Z2VwYWdlX3BhdGgnXQorCitmbWVtaW5mbyA9IG9wZW4oIi9wcm9jL21lbWluZm8i LCAiciIpCit3aGlsZSBmbWVtaW5mbzoKKyAgICAgICBsaW5lID0gZm1lbWluZm8ucmVhZGxp bmUoKQorICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0aCgiSHVnZXBhZ2VzaXplIik6CisgICAg ICAgICAgICAgICBkdW1tLCBocF9zaXplLCBkdW1tID0gbGluZS5zcGxpdCgpCisgICAgICAg ICAgICAgICBicmVhaworZm1lbWluZm8uY2xvc2UoKQorCitpZiBub3QgaHBfc2l6ZToKKyAg ICBwcmludCAiQ291bGQgbm90IGdldCBIdWdlcGFnZXNpemUgZnJvbSAvcHJvYy9tZW1pbmZv IGZpbGUiCisgICAgcmFpc2UgVmFsdWVFcnJvcgorCitpZiB2bXMgPCBtYXhfdm1zOgorICAg IHZtcyA9IG1heF92bXMKKwordm1zbSA9ICgodm1zICogbWVtKSArICh2bXMgKiA2NCkpCit0 YXJnZXQgPSAodm1zbSAqIDEwMjQgLyBpbnQoaHBfc2l6ZSkpIAorCisjIEl0ZXJhdGl2ZWx5 IHNldCAjIG9mIGh1Z2VwYWdlcworZmhwID0gb3BlbigiL3Byb2Mvc3lzL3ZtL25yX2h1Z2Vw YWdlcyIsICJyKyIpCitocCA9IGZocC5yZWFkbGluZSgpCit3aGlsZSBpbnQoaHApIDwgdGFy Z2V0OgorICAgIGhwXyA9IGhwCisgICAgZmhwLndyaXRlKHRhcmdldC5fX3N0cl9fKCkpCisg ICAgZmhwLmZsdXNoKCkKKyAgICB0aW1lLnNsZWVwKDUpCisgICAgZmhwLnNlZWsoMCkKKyAg ICBocCA9IGludChmaHAucmVhZGxpbmUoKSkKKyAgICBpZiBocF8gPT0gaHA6CisgICAgICAg IHJhaXNlIE1lbW9yeUVycm9yCitmaHAuY2xvc2UoKQorCisjIE1vdW50IGh1Z2VwYWdlIGZp bGVzeXN0ZW0sIGlmIG5lY2Vzc2FyaWx5CitmbW91bnQgPSBvcGVuKCIvcHJvYy9tb3VudHMi LCAiciIpCittb3VudCA9IDEKK2xpbmUgPSBmbW91bnQucmVhZGxpbmUoKQord2hpbGUgbGlu ZToKKyAgICBpZiBsaW5lLnNwbGl0KClbMV0gPT0gb3MuZW52aXJvblsnS1ZNX1RFU1RfaHVn ZXBhZ2VfcGF0aCddOgorICAgICAgICBtb3VudCA9IDAKKyAgICAgICAgYnJlYWsKKyAgICBs aW5lID0gZm1vdW50LnJlYWRsaW5lKCkKK2Ztb3VudC5jbG9zZSgpCisKK2lmIG1vdW50Ogor ICAgIGlmIG5vdCBvcy5wYXRoLmV4aXN0cyhodWdlcGFnZV9wYXRoKToKKyAgICAgICAgb3Mu bWFrZWRpcnMoaHVnZXBhZ2VfcGF0aCkKKyAgICBjbWQgPSAibW91bnQgLXQgaHVnZXRsYmZz IG5vbmUgJXMiICUgKGh1Z2VwYWdlX3BhdGgpCisgICAgaWYgb3Muc3lzdGVtKGNtZCk6Cisg ICAgICAgIHJhaXNlIE9TRXJyb3IK --------------060306000708010304040306--