From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] fix serious regression Date: Sun, 26 Jul 2009 17:01:43 +0300 Message-ID: <4A6C61C7.7090400@redhat.com> References: <1248220646-22129-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34487 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753432AbZGZN5S (ORCPT ); Sun, 26 Jul 2009 09:57:18 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6QDvJhw013967 for ; Sun, 26 Jul 2009 09:57:19 -0400 In-Reply-To: <1248220646-22129-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/22/2009 02:57 AM, Glauber Costa wrote: > Today I found a very catastrophic regression: I cannot run my mission > critical servers running RHL7.1 anymore. This is a total disaster. > > Fortunately, I was able to isolate the commit that caused it: > commit bb598da496c040d42dde564bd8ace181be52293e > Author: Glauber Costa > Date: Mon Jul 6 16:12:52 2009 -0400 > > This guy is certainly stupid, and deserves punishment. It means I'll > be writting code using emacs for the next week. > > Marcelo, please apply > > While I appreciate the humour, it means I have to totally rewrite the changelog plus ask a question. Please submit patches with the most boring changelogs you can and reserve the funnies for the "---" section where they belong. > diff --git a/qemu-kvm.c b/qemu-kvm.c > index e200dea..393c5cc 100644 > --- a/qemu-kvm.c > +++ b/qemu-kvm.c > @@ -1003,8 +1003,6 @@ int pre_kvm_run(kvm_context_t kvm, CPUState *env) > { > kvm_arch_pre_kvm_run(kvm->opaque, env); > > - if (env->exit_request) > - return 1; > pthread_mutex_unlock(&qemu_mutex); > return 0; > } > Can you explain the failure mode? -- error compiling committee.c: too many arguments to function