From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Date: Sun, 26 Jul 2009 16:38:44 +0200 Message-ID: <4A6C6A74.4030801@web.de> References: <4A678A56.7050901@web.de> <20090723214553.GA10152@amt.cnet> <4A695C1D.7030807@web.de> <4A6C5F4B.2000902@redhat.com> <4A6C66F2.7010606@web.de> <4A6C69F5.3020604@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0D61D01847C1549B7EAA9C1A" Cc: Marcelo Tosatti , kvm-devel To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:52151 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753534AbZGZOio (ORCPT ); Sun, 26 Jul 2009 10:38:44 -0400 In-Reply-To: <4A6C69F5.3020604@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0D61D01847C1549B7EAA9C1A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 07/26/2009 05:23 PM, Jan Kiszka wrote: >>> btw, what does it fix? a debug warning? >>> >>> =20 >> >> I haven't seen anything in the wild, and I don't think it would raise = a >> warning. All it should cause is a potential delay of some pending >> reschedule as preempt_enable will not fire under local_irq_disable. >> =20 >=20 > Ah, okay, then it is a real fix. Preempt-correctness is important. >=20 > (but won't local_irq_enable() reschedule?) The last time I checked it was essentially a plain 'sti'. Jan --------------enig0D61D01847C1549B7EAA9C1A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpsanQACgkQniDOoMHTA+mhVQCfYs+1gzlthQsGJW46VfsKiveY C3sAn2f4Pi46md7u+H2F058285swmROB =39vJ -----END PGP SIGNATURE----- --------------enig0D61D01847C1549B7EAA9C1A--