From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 2/6] reuse env stop and stopped states Date: Mon, 27 Jul 2009 18:43:47 +0300 Message-ID: <4A6DCB33.5020008@redhat.com> References: <1248214392-12533-1-git-send-email-glommer@redhat.com> <1248214392-12533-2-git-send-email-glommer@redhat.com> <1248214392-12533-3-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44727 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbZG0Pnv (ORCPT ); Mon, 27 Jul 2009 11:43:51 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6RFhpQs020019 for ; Mon, 27 Jul 2009 11:43:51 -0400 In-Reply-To: <1248214392-12533-3-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/22/2009 01:13 AM, Glauber Costa wrote: > qemu CPUState already provides "stop" and "stopped" states. And they > mean exactly that. There is no need for us to provide our own. > > This patch (known as dd0e1c1a589 in qemu-kvm.git) breaks reboot. My test case is FC6 i386 -smp 2, running the reboot command in rc.local. In about 15 minutes qemu hangs hard. Please check what's gone wrong. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.