From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 3/9] change order of kvm_init call. Date: Mon, 27 Jul 2009 13:34:44 -0500 Message-ID: <4A6DF344.6010502@us.ibm.com> References: <1248131416-11272-1-git-send-email-glommer@redhat.com> <1248131416-11272-2-git-send-email-glommer@redhat.com> <1248131416-11272-3-git-send-email-glommer@redhat.com> <1248131416-11272-4-git-send-email-glommer@redhat.com> <4A6CA7A0.8020901@web.de> <20090727173851.GC4776@poweredge.glommer> <4A6DE892.7050801@us.ibm.com> <20090727180003.GE4776@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:56644 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbZG0Seq (ORCPT ); Mon, 27 Jul 2009 14:34:46 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6RISuwE014536 for ; Mon, 27 Jul 2009 14:28:56 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6RIYkDg244994 for ; Mon, 27 Jul 2009 14:34:46 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6RIYkLu025636 for ; Mon, 27 Jul 2009 14:34:46 -0400 In-Reply-To: <20090727180003.GE4776@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > we're not. > > The issue happens exactly when the kvm modules are not loaded, then we're failing > to initialize kvm. However, in the patch that raised this issue, I'm moving > KVM initialization to after this code path. And in qemu-kvm.git, kvm is > enabled-by-default. So tcg code would think kvm is enabled and skip initialization, > while kvm code will fail to really initialize itself later. > That's pure evilness. Good argument to never fall back to TCG. -- Regards, Anthony Liguori