From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: kvm userspace: ksm support Date: Tue, 28 Jul 2009 11:41:28 -0500 Message-ID: <4A6F2A38.30500@codemonkey.ws> References: <20090728193959.49cc28b6@woof.woof> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, "Justin M. Forbes" , Mark McLoughlin To: Izik Eidus Return-path: Received: from mail-px0-f184.google.com ([209.85.216.184]:36792 "EHLO mail-px0-f184.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbZG1Qlc (ORCPT ); Tue, 28 Jul 2009 12:41:32 -0400 Received: by pxi14 with SMTP id 14so107813pxi.33 for ; Tue, 28 Jul 2009 09:41:33 -0700 (PDT) In-Reply-To: <20090728193959.49cc28b6@woof.woof> Sender: kvm-owner@vger.kernel.org List-ID: Izik Eidus wrote: > This patch is not for inclusion just rfc. > The madvise() interface looks really nice :-) > Thanks. > > > From 1297b86aa257100b3d819df9f9f0932bf4f7f49d Mon Sep 17 00:00:00 2001 > From: Izik Eidus > Date: Tue, 28 Jul 2009 19:14:26 +0300 > Subject: [PATCH] kvm userspace: ksm support > > rfc for ksm support to kvm userpsace. > > thanks > > Signed-off-by: Izik Eidus > --- > exec.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/exec.c b/exec.c > index f6d9ec9..375cc18 100644 > --- a/exec.c > +++ b/exec.c > @@ -2595,6 +2595,9 @@ ram_addr_t qemu_ram_alloc(ram_addr_t size) > new_block->host = file_ram_alloc(size, mem_path); > if (!new_block->host) { > new_block->host = qemu_vmalloc(size); > +#ifdef MADV_MERGEABLE > + madvise(new_block->host, size, MADV_MERGEABLE); > +#endif > Are madvise calls additive? Do we need to change the madvise balloon calls to include MADV_MERGEABLE or will this carry the property forever? I'd suggest doing the following in osdep.h too: #if !defined(MADV_MERGABLE) #define MADV_MERGABLE MADV_NORMAL #endif To avoid #ifdefs in .c files. Regards, Anthony Liguori > } > new_block->offset = last_ram_offset; > new_block->length = size; >