From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] simplify creation of kernel irqchip and pit Date: Wed, 29 Jul 2009 15:01:56 +0300 Message-ID: <4A703A34.2090900@redhat.com> References: <1248415027-31313-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44077 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbZG2L5N (ORCPT ); Wed, 29 Jul 2009 07:57:13 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6TBvEFF008630 for ; Wed, 29 Jul 2009 07:57:14 -0400 In-Reply-To: <1248415027-31313-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/24/2009 08:57 AM, Glauber Costa wrote: > Creation of those devices can be a lot simpler. In particular, > if we start by assuming they will be on, and disabling later if > anything fails (user request counts as failing here), we can remove > two variables that really serves no reason. > The patch introduces mixed indentation. Please stick with one style or another. -- error compiling committee.c: too many arguments to function