From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] simplify creation of kernel irqchip and pit
Date: Wed, 29 Jul 2009 16:49:28 +0300 [thread overview]
Message-ID: <4A705368.8050102@redhat.com> (raw)
In-Reply-To: <20090729135000.GA4776@poweredge.glommer>
On 07/29/2009 04:50 PM, Glauber Costa wrote:
> On Wed, Jul 29, 2009 at 03:01:56PM +0300, Avi Kivity wrote:
>
>> On 07/24/2009 08:57 AM, Glauber Costa wrote:
>>
>>> Creation of those devices can be a lot simpler. In particular,
>>> if we start by assuming they will be on, and disabling later if
>>> anything fails (user request counts as failing here), we can remove
>>> two variables that really serves no reason.
>>>
>>>
>> The patch introduces mixed indentation. Please stick with one style or
>> another.
>>
> Are you willin go "apply" my patch that changes everything to four spaces?
> If you are, I'm only resending things after that.
>
I'll look at it. I'm a bit wary about this, it may produce even
brokener indentation. Perhaps a run through indent would help.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-07-29 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 5:57 [PATCH] simplify creation of kernel irqchip and pit Glauber Costa
2009-07-29 12:01 ` Avi Kivity
2009-07-29 13:50 ` Glauber Costa
2009-07-29 13:49 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A705368.8050102@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox