Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state

[Avi Kivity <avi@redhat.com>]

On 07/29/2009 05:07 PM, Marcelo Tosatti wrote:
>> The downside is that we're moving a vmx specific hack to common code.
>>
>> I think this could be simplified if interrupt injection happened outside
>> the critical section.  This is needed anyway because emulated interrupt
>> injection needs to access guest memory (IVT and the stack).
>>      
>
> Why can't it happen now (outside of the critical section), other than
> the kvm_vcpu_kick thing?
>    

I think there's little reason now.  One thing we need to do is make it 
possible to call the injection code twice without entering the guest.  I 
think right now it assumes nothing has been injected.

We need either to cancel a previous injection (a variant of 
vmx_complete_interrupts()), or avoid reinjecting  if we already did.

-- 
error compiling committee.c: too many arguments to function