From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Date: Thu, 30 Jul 2009 14:16:30 +0300 Message-ID: <4A71810E.5010105@redhat.com> References: <4A678A56.7050901@web.de> <20090723214553.GA10152@amt.cnet> <20090729122456.GA16868@amt.cnet> <4A704424.1090602@redhat.com> <20090729140716.GA18751@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Jan Kiszka , kvm-devel To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42454 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbZG3LLl (ORCPT ); Thu, 30 Jul 2009 07:11:41 -0400 In-Reply-To: <20090729140716.GA18751@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 07/29/2009 05:07 PM, Marcelo Tosatti wrote: >> The downside is that we're moving a vmx specific hack to common code. >> >> I think this could be simplified if interrupt injection happened outside >> the critical section. This is needed anyway because emulated interrupt >> injection needs to access guest memory (IVT and the stack). >> > > Why can't it happen now (outside of the critical section), other than > the kvm_vcpu_kick thing? > I think there's little reason now. One thing we need to do is make it possible to call the injection code twice without entering the guest. I think right now it assumes nothing has been injected. We need either to cancel a previous injection (a variant of vmx_complete_interrupts()), or avoid reinjecting if we already did. -- error compiling committee.c: too many arguments to function