From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Date: Thu, 30 Jul 2009 14:46:59 +0300 Message-ID: <4A718833.6030407@redhat.com> References: <4A678A56.7050901@web.de> <20090723214553.GA10152@amt.cnet> <20090729122456.GA16868@amt.cnet> <4A704424.1090602@redhat.com> <20090729140716.GA18751@amt.cnet> <4A71810E.5010105@redhat.com> <20090730111616.GL30449@redhat.com> <4A718360.3040300@redhat.com> <20090730112407.GN30449@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Jan Kiszka , kvm-devel To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38701 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321AbZG3LmL (ORCPT ); Thu, 30 Jul 2009 07:42:11 -0400 In-Reply-To: <20090730112407.GN30449@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/30/2009 02:24 PM, Gleb Natapov wrote: >> Good (it was one of the goals of the original interrupt rework, ~2 years >> ago) >> >> > But if we emulate an injection by playing with guest memory and > registers we have to be sure we do it only once. > Once we've successfully updated the stack, inject is complete and we can remove the interrupt from the queue. -- error compiling committee.c: too many arguments to function