From: Dor Laor <dlaor@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH 0/12] TAP support (and a few other small things)
Date: Mon, 03 Aug 2009 12:24:19 +0300 [thread overview]
Message-ID: <4A76ACC3.5050800@redhat.com> (raw)
In-Reply-To: <1249257501-19337-1-git-send-email-mgoldish@redhat.com>
tcpOn 08/03/2009 02:58 AM, Michael Goldish wrote:
> Here's my proposed TAP solution:
> - The user specifies MAC ranges and may or may not specify corresponding IP
> ranges.
> - VMs are always given MAC addresses from the user specified MAC ranges.
> - MAC address ranges must be unique to each host running KVM tests -- there
> must be no overlap between them.
> - If corresponding IP ranges are specified as well, the system will use them
> when trying to communicate with guests.
> - If corresponding IP ranges are not specified, tcpdump will be used to listen
> to DHCP traffic and dynamically detect the right IP addresses. There's also a
> flag that can force this behavior.
This is pretty nice patch set and it's nice and friendly to hook the
assigned ip address.
Maybe instead of using tcpdump you can add a specific ip tables rule to
trap dhcp replies and log them?
> - tcpdump will run in the background at all times, and collect MAC-IP pairs
> as soon as they are assigned by the DHCP server. This is useful for
> NIC hotplugging (where IP addresses are assigned during the test itself) and
> generally for misbehaving guests or DHCP servers (restarting network services
> during the test, using very short lease times).
> - It is up to the user to create the actual bridge for TAP devices; the
> qemu-ifup script included in one of the patches only adds the TAP interface to
> an existing bridge. The user should modify this script or create a bridge
> some other way.
>
> This works very well on two hosts I tried, but I'm not entirely sure it will
> work in all cases -- please let me know what you think.
>
> (I remember Jason Wang mentioned that tcpdump doesn't always catch all the
> required traffic, or that it might somehow depend on the DHCP server -- anyone
> willing to comment on that?)
>
> The following patches have been tested with a few KVM tests (boot, reboot,
> stress_boot, migration) with both TAP and user mode, but they could probably
> use more testing (maybe with Python 2.6?), so if anyone is willing to help
> with that I'd appreciate it very much.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-08-03 9:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-02 23:58 [KVM-AUTOTEST PATCH 0/12] TAP support (and a few other small things) Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 01/12] KVM test: add some MAC/IP address utilities to kvm_utils Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 02/12] KVM test: add basic TAP support with static MAC-IP mapping Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 03/12] KVM test: add sample 'qemu-ifup' script Michael Goldish
2009-08-05 12:10 ` [Autotest] " Lucas Meneghel Rodrigues
2009-08-05 12:51 ` Michael Goldish
2009-08-06 5:41 ` sudhir kumar
2009-08-06 11:42 ` Lucas Meneghel Rodrigues
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 04/12] KVM test: add host-specific MAC-IP pool configuration Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 05/12] KVM test: specify installation cdkeys in a dedicated file Michael Goldish
2009-08-05 12:15 ` [Autotest] " Lucas Meneghel Rodrigues
2009-08-05 14:02 ` Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 06/12] KVM test: minor style changes to kvm_config.py Michael Goldish
2009-08-07 21:47 ` [Autotest] " Lucas Meneghel Rodrigues
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 07/12] KVM test: kvm_config.py: do not fail when including a nonexistent file Michael Goldish
2009-08-07 21:51 ` [Autotest] " Lucas Meneghel Rodrigues
2009-08-07 22:24 ` Michael Goldish
2009-08-07 23:19 ` Lucas Meneghel Rodrigues
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 08/12] KVM test: kvm_subprocess: send user specified parameters to kvm_tail callbacks Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 09/12] KVM test: dynamically detect and cache MAC-IP pairs using tcpdump Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 10/12] KVM test: kvm_utils.py: small fix for format_str_for_message() Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 11/12] KVM test: make VMs use a dynamic MAC-IP mapping generated by tcpdump Michael Goldish
2009-08-02 23:58 ` [KVM-AUTOTEST PATCH 12/12] KVM test: make stress_boot work properly with TAP networking Michael Goldish
2009-08-03 3:17 ` Yolkfull Chow
2009-08-03 9:24 ` Dor Laor [this message]
2009-08-03 9:39 ` [KVM-AUTOTEST PATCH 0/12] TAP support (and a few other small things) Michael Goldish
2009-08-03 11:57 ` Dor Laor
2009-08-03 14:10 ` [Autotest] " Lucas Meneghel Rodrigues
[not found] <644193195.1369451249307151747.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-03 13:51 ` Michael Goldish
2009-08-04 10:23 ` Dor Laor
[not found] <1229225061.1424411249383399566.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-04 11:00 ` Michael Goldish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A76ACC3.5050800@redhat.com \
--to=dlaor@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox