From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request
Date: Mon, 03 Aug 2009 15:18:38 +0300 [thread overview]
Message-ID: <4A76D59E.4020102@redhat.com> (raw)
In-Reply-To: <20090721000054.GB15189@amt.cnet>
On 07/21/2009 03:00 AM, Marcelo Tosatti wrote:
> Jan,
>
> This was suggested but we thought it might be safer to keep the
> get_cpu/put_cpu pair in case -rt kernels require it (which might be
> bullshit, but nobody verified).
>
>
Thinking about it, it is bullshit:
>>
>> - me = get_cpu();
>> spin_lock(&kvm->requests_lock);
>> + me = smp_processor_id();
>>
The -rt kernel cannot substitute a mutex for the spinlock here, since we
are pinned to a single cpu. It will have to use a raw spinlock here.
However, the 'me' variable is completely spurious. It only affects the
statistics gathering, I think we can safely drop it.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-08-03 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 9:30 [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request Jan Kiszka
2009-07-20 19:46 ` Andrea Arcangeli
2009-07-21 0:00 ` Marcelo Tosatti
2009-07-21 8:24 ` Jan Kiszka
2009-07-21 17:10 ` Marcelo Tosatti
2009-07-21 23:29 ` Jan Kiszka
2009-07-21 23:37 ` Marcelo Tosatti
2009-08-03 12:18 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A76D59E.4020102@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox