From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH v2] KVM: x86: Disallow hypercalls for guest callers in rings > 0
Date: Tue, 04 Aug 2009 15:00:57 +0300 [thread overview]
Message-ID: <4A7822F9.7030706@redhat.com> (raw)
In-Reply-To: <4A7713B0.8080803@siemens.com>
On 08/03/2009 07:43 PM, Jan Kiszka wrote:
>
> Yes, that's much nicer.
>
> --------->
>
> So far unprivileged guest callers running in ring 3 can issue, e.g., MMU
> hypercalls. Normally, such callers cannot provide any hand-crafted MMU
> command structure as it has to be passed by its physical address, but
> they can still crash the guest kernel by passing random addresses.
>
> To close the hole, this patch considers hypercalls valid only if issued
> from guest ring 0. This may still be relaxed on a per-hypercall base in
> the future once required.
>
> Changes v1 -> v2:
> - use kvm_x86_ops->get_cpl() in favor of kvm_get_segment()
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-08-04 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 13:47 [PATCH] KVM: x86: Disallow hypercalls for guest callers in rings > 0 Jan Kiszka
2009-08-03 14:04 ` Anthony Liguori
2009-08-03 14:24 ` Avi Kivity
2009-08-03 15:04 ` Anthony Liguori
2009-08-03 16:01 ` Avi Kivity
2009-08-03 14:27 ` Avi Kivity
2009-08-03 16:43 ` [PATCH v2] " Jan Kiszka
2009-08-04 12:00 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7822F9.7030706@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).