From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: fix ack not being delivered when msi present Date: Wed, 05 Aug 2009 14:08:23 +0300 Message-ID: <4A796827.9010905@redhat.com> References: <20090726141001.GA21167@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@redhat.com, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51310 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbZHELC4 (ORCPT ); Wed, 5 Aug 2009 07:02:56 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n75B2vEg000907 for ; Wed, 5 Aug 2009 07:02:57 -0400 In-Reply-To: <20090726141001.GA21167@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/26/2009 05:10 PM, Michael S. Tsirkin wrote: > kvm_notify_acked_irq does not check irq type, so that it sometimes > interprets msi vector as irq. As a result, ack notifiers are not > called, which typially hangs the guest. The fix is to track and > check irq type. > Applied, thanks. -- error compiling committee.c: too many arguments to function