From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [autotest] vm creation fails (not) Date: Wed, 05 Aug 2009 18:43:33 +0300 Message-ID: <4A79A8A5.20004@redhat.com> References: <186914453.1505591249481143448.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , KVM list To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51087 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755772AbZHEPiD (ORCPT ); Wed, 5 Aug 2009 11:38:03 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n75Fc5Sj002241 for ; Wed, 5 Aug 2009 11:38:05 -0400 In-Reply-To: <186914453.1505591249481143448.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/05/2009 05:05 PM, Michael Goldish wrote: > Thanks, I managed to reproduce it and I'll send a patch to fix it soon. > The reason for autotest thinking qemu wasn't alive was that apparently it > takes time for /proc/$PID/cmdline to reflect the real command used to > start the process, and I wrongly assumed it was instantaneous. > You should use wait() to find out if the process is alive, not tricks with the PID and process name, which are racy as you found out. -- error compiling committee.c: too many arguments to function