public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Lalancette <clalance@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: [PATCH]: Always use KVM_VERSION to build version number
Date: Fri, 07 Aug 2009 14:31:18 +0200	[thread overview]
Message-ID: <4A7C1E96.3060200@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

Avi,
     Trying to use libvirt with development snapshots of qemu-kvm is a bit
problematic.  The trouble is that for all development snapshots, the value that
gets placed into this string:

QEMU PC emulator version 0.10.0 (kvm-devel), Copyright (c) 2003-2008

Is always kvm-devel.  That means we can't tell if this is a kvm development
snapshot built yesterday, or 6 months ago, which means that in turn we can't
tell what features are available.  While we can always tell people building
their own qemu to force it by echoing a value into KVM_VERSION, it would be much
better if this were done by default.  Something like kvm-88-devel, which would
signify that this the development happening after kvm-88, leading towards
kvm-89.  Would you accept something like the patch below, which would require
you to edit the KVM_VERSION file twice during a release (once right before the
release, to change it to kvm-89, and once right after the release to change it
back to kvm-89-devel)?

Signed-off-by: Chris Lalancette <clalance@redhat.com>

[-- Attachment #2: kvm-version.patch --]
[-- Type: text/x-patch, Size: 143 bytes --]

diff --git a/KVM_VERSION b/KVM_VERSION
new file mode 100644
index 0000000..efd3e0e
--- /dev/null
+++ b/KVM_VERSION
@@ -0,0 +1 @@
+kvm-88-devel

             reply	other threads:[~2009-08-07 12:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07 12:31 Chris Lalancette [this message]
2009-08-09  9:58 ` [PATCH]: Always use KVM_VERSION to build version number Avi Kivity
2009-08-10  9:19   ` Mark McLoughlin
2009-08-10  9:39     ` [PATCH] configure: make default KVM_VERSION qemu-kvm-devel Mark McLoughlin
2009-08-10  9:47       ` Avi Kivity
2009-08-10  9:46     ` [PATCH]: Always use KVM_VERSION to build version number Avi Kivity
2009-08-10  9:52       ` Mark McLoughlin
2009-08-10 10:12         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7C1E96.3060200@redhat.com \
    --to=clalance@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox