From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Lalancette Subject: [PATCH]: Always use KVM_VERSION to build version number Date: Fri, 07 Aug 2009 14:31:18 +0200 Message-ID: <4A7C1E96.3060200@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050901060706020504060802" Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35596 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757258AbZHGMbT (ORCPT ); Fri, 7 Aug 2009 08:31:19 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n77CVK01003727 for ; Fri, 7 Aug 2009 08:31:20 -0400 Sender: kvm-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------050901060706020504060802 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Avi, Trying to use libvirt with development snapshots of qemu-kvm is a bit problematic. The trouble is that for all development snapshots, the value that gets placed into this string: QEMU PC emulator version 0.10.0 (kvm-devel), Copyright (c) 2003-2008 Is always kvm-devel. That means we can't tell if this is a kvm development snapshot built yesterday, or 6 months ago, which means that in turn we can't tell what features are available. While we can always tell people building their own qemu to force it by echoing a value into KVM_VERSION, it would be much better if this were done by default. Something like kvm-88-devel, which would signify that this the development happening after kvm-88, leading towards kvm-89. Would you accept something like the patch below, which would require you to edit the KVM_VERSION file twice during a release (once right before the release, to change it to kvm-89, and once right after the release to change it back to kvm-89-devel)? Signed-off-by: Chris Lalancette --------------050901060706020504060802 Content-Type: text/x-patch; name="kvm-version.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="kvm-version.patch" diff --git a/KVM_VERSION b/KVM_VERSION new file mode 100644 index 0000000..efd3e0e --- /dev/null +++ b/KVM_VERSION @@ -0,0 +1 @@ +kvm-88-devel --------------050901060706020504060802--