From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 06/10] Move irq routing to its own locking. Date: Sun, 09 Aug 2009 17:52:14 +0300 Message-ID: <4A7EE29E.7040306@redhat.com> References: <1249821671-32356-1-git-send-email-gleb@redhat.com> <1249821671-32356-7-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38054 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945AbZHIOqS (ORCPT ); Sun, 9 Aug 2009 10:46:18 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n79EkJUr028270 for ; Sun, 9 Aug 2009 10:46:19 -0400 In-Reply-To: <1249821671-32356-7-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/09/2009 03:41 PM, Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > --- > include/linux/kvm_host.h | 1 + > virt/kvm/irq_comm.c | 4 ++-- > virt/kvm/kvm_main.c | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index d573652..ce28cb7 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -175,6 +175,7 @@ struct kvm { > struct mutex irq_lock; > #ifdef CONFIG_HAVE_KVM_IRQCHIP > struct kvm_irq_routing_table *irq_routing; > + spinlock_t irq_routing_lock; > Why is this needed? The irq routing table adds very little contention since it is rcu locked. -- error compiling committee.c: too many arguments to function