From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] configure: make default KVM_VERSION qemu-kvm-devel Date: Mon, 10 Aug 2009 12:47:43 +0300 Message-ID: <4A7FECBF.8000906@redhat.com> References: <4A7C1E96.3060200@redhat.com> <4A7E9DA9.3060204@redhat.com> <1249895994.8784.47.camel@blaa> <1249897162.8784.66.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Lalancette , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45068 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300AbZHJJlj (ORCPT ); Mon, 10 Aug 2009 05:41:39 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7A9feRq006479 for ; Mon, 10 Aug 2009 05:41:40 -0400 In-Reply-To: <1249897162.8784.66.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On 08/10/2009 12:39 PM, Mark McLoughlin wrote: > Released versions of qemu-kvm now have a KVM_VERSION of either > qemu-kvm-x.y.z or qemu-kvm-devel-XX. However, when building from git, > KVM_VERSION is kvm-devel. > > Defaulting to qemu-kvm-devel makes more sense. > > With newer versions of qemu-kvm, libvirt actually ignores the kvm > snapshot number (i.e. 86, 87 etc.) and just uses the 'qemu-kvm-' > string to detect that this is the kvm fork of qemu. The actual kvm > snapshot number is no longer important, it's the qemu version number > which is important. > Applied, thanks. -- error compiling committee.c: too many arguments to function