From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/8 v2] Move IO APIC to its own lock. Date: Wed, 12 Aug 2009 13:07:56 +0300 Message-ID: <4A82947C.10303@redhat.com> References: <1249993895-11119-1-git-send-email-gleb@redhat.com> <1249993895-11119-7-git-send-email-gleb@redhat.com> <4A827CE1.7040304@redhat.com> <20090812090458.GZ4764@redhat.com> <4A8288D2.9000607@redhat.com> <20090812094708.GB4764@redhat.com> <4A8291F3.2030106@redhat.com> <20090812100503.GD4764@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45290 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932068AbZHLKIA (ORCPT ); Wed, 12 Aug 2009 06:08:00 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7CA81wv007529 for ; Wed, 12 Aug 2009 06:08:01 -0400 In-Reply-To: <20090812100503.GD4764@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/12/2009 01:05 PM, Gleb Natapov wrote: > > >> Let's leave _irqsave() until later since that has other implications. >> >> > So change it to mutex then? > > Yes please. >>> Doing this will just re-enable host interrupt while irq condition is not >>> cleared in the device. The host will hang. So I think we really shouldn't. >>> >>> >> Ok. What about timer acks? >> >> > Interrupt wasn't processed by a guest. Why should it be accounted as > such? > Good question. I guess it shouldn't. -- error compiling committee.c: too many arguments to function