From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] When switching to a vm8086 task, load segments as 16-bit (v2) Date: Wed, 12 Aug 2009 16:40:45 +0300 Message-ID: <4A82C65D.7010007@redhat.com> References: <1250024279-6307-1-git-send-email-aliguori@us.ibm.com> <4A82B177.9030607@redhat.com> <4A82B769.3060608@redhat.com> <4A82C06B.10400@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Gleb Natapov To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44325 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbZHLNk6 (ORCPT ); Wed, 12 Aug 2009 09:40:58 -0400 In-Reply-To: <4A82C06B.10400@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/12/2009 04:15 PM, Anthony Liguori wrote: > While the code looks nicer with the second patch, the fact that > get_rflags() does a vmcs_read() seems 7 times more than before seems > unfortunate. We can add kvm_rflags_read(), see kvm_cache_regs.h. In any case, it's purely academic since task switches are rare and incredibly slow anyway (you have to vmcs_write() the entire register set for one). -- error compiling committee.c: too many arguments to function