From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] When switching to a vm8086 task, load segments as 16-bit (v2) Date: Wed, 12 Aug 2009 08:50:29 -0500 Message-ID: <4A82C8A5.9070601@us.ibm.com> References: <1250024279-6307-1-git-send-email-aliguori@us.ibm.com> <4A82B177.9030607@redhat.com> <4A82B769.3060608@redhat.com> <4A82C06B.10400@us.ibm.com> <4A82C65D.7010007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Gleb Natapov To: Avi Kivity Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:57492 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbZHLNub (ORCPT ); Wed, 12 Aug 2009 09:50:31 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n7CDsQs7020099 for ; Wed, 12 Aug 2009 09:54:26 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7CDoV97246240 for ; Wed, 12 Aug 2009 09:50:32 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7CDoVUo005651 for ; Wed, 12 Aug 2009 09:50:31 -0400 In-Reply-To: <4A82C65D.7010007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 08/12/2009 04:15 PM, Anthony Liguori wrote: >> While the code looks nicer with the second patch, the fact that >> get_rflags() does a vmcs_read() seems 7 times more than before seems >> unfortunate. > > We can add kvm_rflags_read(), see kvm_cache_regs.h. In any case, it's > purely academic since task switches are rare and incredibly slow > anyway (you have to vmcs_write() the entire register set for one). Fair enough. -- Regards, Anthony Liguori