From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] Reordering how tap is initialized
Date: Fri, 14 Aug 2009 08:25:26 -0500
Message-ID: <4A8565C6.2020507@codemonkey.ws>
References: <Pine.LNX.4.64.0908140816510.28989@anvil.nuitari.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Stephane Bakhos <nuitari-kvm@nuitari.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qy0-f196.google.com ([209.85.221.196]:63800 "EHLO
	mail-qy0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755778AbZHNNZ2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 14 Aug 2009 09:25:28 -0400
Received: by qyk34 with SMTP id 34so1138788qyk.33
        for <kvm@vger.kernel.org>; Fri, 14 Aug 2009 06:25:29 -0700 (PDT)
In-Reply-To: <Pine.LNX.4.64.0908140816510.28989@anvil.nuitari.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Stephane Bakhos wrote:
> This is my first patch, so I apoligize for breaking any convention.
>
> This patch modifies the order used in net.c for tap initialization.
> It runs the script before the device is opened.

This will break existing scripts that do not rely on explicitly setting 
ifname= and instead rely on tap_open() to allocate a tap device.  In 
fact, this is one of the most common usages.

Regards,

Anthony Liguori