From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] Re: virtio-serial: An interface for host-guest communication Date: Fri, 14 Aug 2009 11:25:32 -0500 Message-ID: <4A858FFC.7000607@codemonkey.ws> References: <20090806173740.GA1178@shareable.org> <20090807063800.GA16769@amit-x200.redhat.com> <4A7C36D3.3040305@codemonkey.ws> <20090810065508.GA4499@amit-x200.redhat.com> <4A7FECCA.8080804@redhat.com> <4A801A7B.1020208@codemonkey.ws> <4A80287C.7050400@redhat.com> <4A802CA7.9020701@codemonkey.ws> <4A803E07.7080407@redhat.com> <4A8051F3.7040400@codemonkey.ws> <20090814081518.GA7418@amit-x200.redhat.com> <4A856B5E.2000303@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amit Shah , kvm@vger.kernel.org, qemu-devel@nongnu.org, Rusty Russell , virtualization@lists.linux-foundation.org To: Gerd Hoffmann Return-path: Received: from mail-yx0-f175.google.com ([209.85.210.175]:45472 "EHLO mail-yx0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755636AbZHNQZe (ORCPT ); Fri, 14 Aug 2009 12:25:34 -0400 Received: by yxe5 with SMTP id 5so2008528yxe.33 for ; Fri, 14 Aug 2009 09:25:35 -0700 (PDT) In-Reply-To: <4A856B5E.2000303@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gerd Hoffmann wrote: > On 08/14/09 10:15, Amit Shah wrote: >> The guest code sort-of ends up looking like this after merging >> virtio_console into virtio_serial. > > I think it should better go the other way around: add multichannel > support to virtio-concole, probably guarded by a feature flag so old > host+new guest and new host+old guest combinations continue to work. > >> Since there's support for only one console as of now, I've assigned port >> #2 as the console port so that we hook into hvc when a port is found at >> that location. > > Doesn't sound like this is going to be backward compatible ... > > Also I still think passing a 'protocol' string for each port is a good > idea, so you can stick that into a sysfs file for guests use. Or drops ports altogether and just use protocol strings... Regards, Anthony Liguori