Re: [PATCH] Move irq sharing information to irqchip level.

[Avi Kivity <avi@redhat.com>]

On 08/13/2009 08:19 PM, Gleb Natapov wrote:
> This removes assumptions that max GSIs is smaller than number of pins.
> Sharing is tracked on pin level not GSI level.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index b17d845..4c15bdd 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -413,7 +413,6 @@ struct kvm_arch{
>   	gpa_t ept_identity_map_addr;
>
>   	unsigned long irq_sources_bitmap;
> -	unsigned long irq_states[KVM_IOAPIC_NUM_PINS];
>   	u64 vm_init_tsc;
>   };
>
> diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h
> index 7d6058a..c025a23 100644
> --- a/arch/x86/kvm/irq.h
> +++ b/arch/x86/kvm/irq.h
> @@ -71,6 +71,7 @@ struct kvm_pic {
>   	int output;		/* intr from master PIC */
>   	struct kvm_io_device dev;
>   	void (*ack_notifier)(void *opaque, int irq);
> +	unsigned long irq_states[16];
>   };
>
>    

I think it's cleaner to move this into the routing table to avoid 
duplication.  Currently there is no object which is unique to a gsi, but 
after your array patch, it can be placed next to the hlist_head.

-- 
error compiling committee.c: too many arguments to function