From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3 0/8] make interrupt injection lockless (almost) Date: Mon, 17 Aug 2009 12:46:53 +0300 Message-ID: <4A89270D.5030705@redhat.com> References: <1250079442-5163-1-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38786 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbZHQJqz (ORCPT ); Mon, 17 Aug 2009 05:46:55 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7H9kujZ025414 for ; Mon, 17 Aug 2009 05:46:56 -0400 In-Reply-To: <1250079442-5163-1-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/12/2009 03:17 PM, Gleb Natapov wrote: > kvm->irq_lock protects too much stuff, but still fail to protect > everything it was design to protect (see ack notifiers call in pic). I > want to make IRQ injection fast path as lockless as possible. This patch > series removes kvm->irq_lock from irq injection path effectively making > interrupt injection to lapic lockless (several kvm_irq_delivery_to_apic() > may run in parallel), but access to lapic was never fully locked in the > first place. VCPU could access lapic in parallel with interrupt injection. > Patches 1/2 changes irq routing data structure to much more efficient one. > Apart from my small comments it looks ready. Please drop the pic reset changes to reduce risks. -- error compiling committee.c: too many arguments to function