From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Live migration stops working... (SEGFAULT) Date: Tue, 18 Aug 2009 15:12:26 +0300 Message-ID: <4A8A9AAA.7050305@redhat.com> References: <1250536345-31917-1-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040304010207030401060106" Cc: Andre Przywara , thomas.besser@kit.edu, kvm@vger.kernel.org To: Stephane Bakhos Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36202 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758662AbZHRMMo (ORCPT ); Tue, 18 Aug 2009 08:12:44 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------040304010207030401060106 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 08/18/2009 11:11 AM, Stephane Bakhos wrote: > > I've tried the patch and it did not help, however I could only have it > on the receiver of the migration. Would it need to be installed on the > one sending the data ? > > The guest kernel and userland are 32bits, the host's are 64 bits. > > I do not see any message about a faulting init. It needs to be on both. However try this better patch (attached, needs to be on both hosts). -- error compiling committee.c: too many arguments to function --------------040304010207030401060106 Content-Type: text/x-patch; name="fix-sysenter-on-amd.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-sysenter-on-amd.patch" diff --git a/kvm/kernel/x86/svm.c b/kvm/kernel/x86/svm.c index e158a2f..6df3cea 100644 --- a/kvm/kernel/x86/svm.c +++ b/kvm/kernel/x86/svm.c @@ -101,9 +101,6 @@ struct vcpu_svm { unsigned long vmcb_pa; struct svm_cpu_data *svm_data; uint64_t asid_generation; - uint64_t sysenter_cs; - uint64_t sysenter_esp; - uint64_t sysenter_eip; u64 next_rip; @@ -2087,13 +2084,13 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data) break; #endif case MSR_IA32_SYSENTER_CS: - *data = svm->sysenter_cs; + *data = svm->vmcb->save.sysenter_cs; break; case MSR_IA32_SYSENTER_EIP: - *data = svm->sysenter_eip; + *data = svm->vmcb->save.sysenter_eip; break; case MSR_IA32_SYSENTER_ESP: - *data = svm->sysenter_esp; + *data = svm->vmcb->save.sysenter_esp; break; /* Nobody will change the following 5 values in the VMCB so we can safely return them on rdmsr. They will always be 0 @@ -2176,13 +2173,13 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 data) break; #endif case MSR_IA32_SYSENTER_CS: - svm->sysenter_cs = data; + svm->vmcb->save.sysenter_cs = data; break; case MSR_IA32_SYSENTER_EIP: - svm->sysenter_eip = data; + svm->vmcb->save.sysenter_eip = data; break; case MSR_IA32_SYSENTER_ESP: - svm->sysenter_esp = data; + svm->vmcb->save.sysenter_esp = data; break; case MSR_IA32_DEBUGCTLMSR: if (!svm_has(SVM_FEATURE_LBRV)) { --------------040304010207030401060106--