From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: arcezed@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix NULL pointer reference by update_cr8_intercept()
Date: Wed, 19 Aug 2009 11:07:42 +0300 [thread overview]
Message-ID: <4A8BB2CE.80006@redhat.com> (raw)
In-Reply-To: <1250650329-28537-1-git-send-email-sheng@linux.intel.com>
On 08/19/2009 05:52 AM, Sheng Yang wrote:
> Commit 0d11419a result in NULL pointer reference when using
> --no-kvm-irqchip.
>
> Signed-off-by: Sheng Yang<sheng@linux.intel.com>
> ---
> arch/x86/kvm/x86.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 850cf56..9ac2d9e 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4453,7 +4453,8 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu,
> kvm_set_segment(vcpu,&sregs->tr, VCPU_SREG_TR);
> kvm_set_segment(vcpu,&sregs->ldt, VCPU_SREG_LDTR);
>
> - update_cr8_intercept(vcpu);
> + if (kvm_lapic_enabled(vcpu))
> + update_cr8_intercept(vcpu);
>
>
Thanks, I already have a similar fix in update_cr8_intercept() (since it
can be called from another callsite as well). Please check kvm-next.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-08-19 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 2:52 [PATCH] KVM: Fix NULL pointer reference by update_cr8_intercept() Sheng Yang
2009-08-19 8:07 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8BB2CE.80006@redhat.com \
--to=avi@redhat.com \
--cc=arcezed@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).