* [PATCH] Add adc and sbb missing decoder flags
@ 2009-08-18 12:59 Mohammed Gamal
2009-08-18 14:41 ` Avi Kivity
0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Gamal @ 2009-08-18 12:59 UTC (permalink / raw)
To: avi; +Cc: kvm, Mohammed Gamal
Add missing decoder flags for adc and sbb instructions
(opcodes 0x14-0x15, 0x1c-0x1d)
Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
arch/x86/kvm/emulate.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 438d423..af58e54 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -101,11 +101,13 @@ static u32 opcode_table[256] = {
/* 0x10 - 0x17 */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
- 0, 0, ImplicitOps | Stack, ImplicitOps | Stack,
+ ByteOp | DstAcc | SrcImm, DstAcc | SrcImm,
+ ImplicitOps | Stack, ImplicitOps | Stack,
/* 0x18 - 0x1F */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
- 0, 0, ImplicitOps | Stack, ImplicitOps | Stack,
+ ByteOp | DstAcc | SrcImm, DstAcc | SrcImm,
+ ImplicitOps | Stack, ImplicitOps | Stack,
/* 0x20 - 0x27 */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Add adc and sbb missing decoder flags
2009-08-18 12:59 Mohammed Gamal
@ 2009-08-18 14:41 ` Avi Kivity
2009-08-18 19:41 ` Mohammed Gamal
0 siblings, 1 reply; 5+ messages in thread
From: Avi Kivity @ 2009-08-18 14:41 UTC (permalink / raw)
To: Mohammed Gamal; +Cc: kvm
On 08/18/2009 03:59 PM, Mohammed Gamal wrote:
> Add missing decoder flags for adc and sbb instructions
> (opcodes 0x14-0x15, 0x1c-0x1d)
>
This depends on the previous patch, so I'll just wait until that is ready.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add adc and sbb missing decoder flags
2009-08-18 14:41 ` Avi Kivity
@ 2009-08-18 19:41 ` Mohammed Gamal
0 siblings, 0 replies; 5+ messages in thread
From: Mohammed Gamal @ 2009-08-18 19:41 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
On Tue, Aug 18, 2009 at 5:41 PM, Avi Kivity<avi@redhat.com> wrote:
> On 08/18/2009 03:59 PM, Mohammed Gamal wrote:
>>
>> Add missing decoder flags for adc and sbb instructions
>> (opcodes 0x14-0x15, 0x1c-0x1d)
>>
>
> This depends on the previous patch, so I'll just wait until that is ready.
>
I'll rebase this on the current tree and resend it.
> --
> error compiling committee.c: too many arguments to function
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Add adc and sbb missing decoder flags
@ 2009-08-18 22:26 Mohammed Gamal
2009-08-19 8:24 ` Avi Kivity
0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Gamal @ 2009-08-18 22:26 UTC (permalink / raw)
To: avi; +Cc: kvm, Mohammed Gamal
Add missing decoder flags for adc and sbb instructions
(opcodes 0x14-0x15, 0x1c-0x1d)
[Rebased to upstream tree]
Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
arch/x86/kvm/emulate.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 2eb807a..1be5cd6 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -100,11 +100,11 @@ static u32 opcode_table[256] = {
/* 0x10 - 0x17 */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
- 0, 0, 0, 0,
+ ByteOp | DstAcc | SrcImm, DstAcc | SrcImm, 0, 0,
/* 0x18 - 0x1F */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
- 0, 0, 0, 0,
+ ByteOp | DstAcc | SrcImm, DstAcc | SrcImm, 0, 0,
/* 0x20 - 0x27 */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Add adc and sbb missing decoder flags
2009-08-18 22:26 [PATCH] Add adc and sbb missing decoder flags Mohammed Gamal
@ 2009-08-19 8:24 ` Avi Kivity
0 siblings, 0 replies; 5+ messages in thread
From: Avi Kivity @ 2009-08-19 8:24 UTC (permalink / raw)
To: Mohammed Gamal; +Cc: kvm
On 08/19/2009 01:26 AM, Mohammed Gamal wrote:
> Add missing decoder flags for adc and sbb instructions
> (opcodes 0x14-0x15, 0x1c-0x1d)
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-08-19 8:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-18 22:26 [PATCH] Add adc and sbb missing decoder flags Mohammed Gamal
2009-08-19 8:24 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2009-08-18 12:59 Mohammed Gamal
2009-08-18 14:41 ` Avi Kivity
2009-08-18 19:41 ` Mohammed Gamal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).