From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org, zamsden@redhat.com
Subject: Re: [PATCH][RFC] Use return value from kvm_set_irq() to re-inject PIT interrupts.
Date: Wed, 26 Aug 2009 16:48:14 +0300 [thread overview]
Message-ID: <4A953D1E.4020007@redhat.com> (raw)
In-Reply-To: <20090826133842.GB676@amt.cnet>
On 08/26/2009 04:38 PM, Marcelo Tosatti wrote:
>
> An injectable timer interrupt is defined by:
>
> - time(now)>= time(next_expiration)
> - Previous timer interrupt has been acked (thus we can inject).
>
> The thing is, sure you can drop ack notifiers and check IRR
> on every guest entry, but why bother if you can receive an
> asynchronous notification?
>
> Would you prefer to replace
>
> + if (!ktimer->can_inject)
>
> With
> kvm_set_irq()
>
> ?
>
> Not relatively cheap.
>
Well, we expect it to be a rare condition that we have pending timer
interrupts, so if it leads to significant code simplification, it can be
worthwhile.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-08-26 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 12:06 [PATCH][RFC] Use return value from kvm_set_irq() to re-inject PIT interrupts Gleb Natapov
2009-08-24 16:32 ` Marcelo Tosatti
2009-08-24 17:16 ` Gleb Natapov
2009-08-24 17:44 ` Marcelo Tosatti
2009-08-24 18:19 ` Gleb Natapov
2009-08-24 19:01 ` Gleb Natapov
2009-08-26 12:45 ` Marcelo Tosatti
2009-08-26 12:43 ` Marcelo Tosatti
2009-08-26 13:19 ` Gleb Natapov
2009-08-26 13:38 ` Marcelo Tosatti
2009-08-26 13:48 ` Avi Kivity [this message]
2009-08-26 13:50 ` Gleb Natapov
2009-08-26 13:49 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A953D1E.4020007@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).