From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: KVM pvmmu: do not batch pte updates from interrupt context
Date: Thu, 27 Aug 2009 11:11:11 +0300 [thread overview]
Message-ID: <4A963F9F.90003@redhat.com> (raw)
In-Reply-To: <20090825041310.GA15313@amt.cnet>
On 08/25/2009 07:13 AM, Marcelo Tosatti wrote:
> Commit b8bcfe997e4 made paravirt pte updates synchronous in interrupt
> context.
>
> Unfortunately the KVM pv mmu code caches the lazy/nonlazy mode
> internally, so a pte update from interrupt context during a lazy mmu
> operation can be batched while it should be performed synchronously.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=518022
>
> Drop the internal mode variable and use paravirt_get_lazy_mode(), which
> returns the correct state.
>
>
It looks good and I'd like to get it into 2.6.31. Do we have any
reports it fixes the problem?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-08-27 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 4:13 KVM pvmmu: do not batch pte updates from interrupt context Marcelo Tosatti
2009-08-27 8:11 ` Avi Kivity [this message]
2009-08-27 13:00 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A963F9F.90003@redhat.com \
--to=avi@redhat.com \
--cc=jeremy@goop.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).