From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM pvmmu: do not batch pte updates from interrupt context Date: Thu, 27 Aug 2009 11:11:11 +0300 Message-ID: <4A963F9F.90003@redhat.com> References: <20090825041310.GA15313@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm , Jeremy Fitzhardinge To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56010 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbZH0ILM (ORCPT ); Thu, 27 Aug 2009 04:11:12 -0400 In-Reply-To: <20090825041310.GA15313@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 08/25/2009 07:13 AM, Marcelo Tosatti wrote: > Commit b8bcfe997e4 made paravirt pte updates synchronous in interrupt > context. > > Unfortunately the KVM pv mmu code caches the lazy/nonlazy mode > internally, so a pte update from interrupt context during a lazy mmu > operation can be batched while it should be performed synchronously. > > https://bugzilla.redhat.com/show_bug.cgi?id=518022 > > Drop the internal mode variable and use paravirt_get_lazy_mode(), which > returns the correct state. > > It looks good and I'd like to get it into 2.6.31. Do we have any reports it fixes the problem? -- error compiling committee.c: too many arguments to function