From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code Date: Thu, 27 Aug 2009 11:15:23 +0300 Message-ID: <4A96409B.3020001@redhat.com> References: <20090827012000.762063112@localhost.localdomain> <20090827012955.208915957@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbZH0IPY (ORCPT ); Thu, 27 Aug 2009 04:15:24 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7R8FQDD020711 for ; Thu, 27 Aug 2009 04:15:26 -0400 In-Reply-To: <20090827012955.208915957@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 08/27/2009 04:20 AM, Marcelo Tosatti wrote: > Split KVM_REQ_KICKED in two bits: KVM_VCPU_KICKED, to indicate > whether a vcpu has been IPI'ed, and KVM_VCPU_GUEST_MODE, in a separate > vcpu_state variable. > > Unify remote requests with kvm_vcpu_kick. > > Synchronous requests wait on KVM_VCPU_GUEST_MODE, via wait_on_bit/wake_up_bit. > > I did miss guest_mode. > + unsigned long vcpu_state; > Why not bool guest_mode? Saves two atomics per exit. -- error compiling committee.c: too many arguments to function